BIP100: Dynamic maximum block size by miner vote #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgenr8
force-pushed
the
bip100
branch
2 times, most recently
from
7c3ccf1
to
4684ec6
Compare
|
Pushed a parser bugfix from @dagurval. We'll squash these after a while. |
|
Pushed changes to support specification update jgarzik/bip100#20. |
|
Pushed coinbaseaux support from @dagurval. |
With Dagur Johannsson <dagurval@pvv.ntnu.no>
Unit tests for GetNextMaxBlockSize and FindVote. Multi-node voting regression test. With Tom Harding <tomh@thinlink.com> Includes regtest routines by Gavin Andresen <gavinandresen@gmail.com>
|
Pushed vote search edge cases and some squashes. |
Max sigops calculation changed to use actual block size rather than hardLimit
This adds BIP100 votes to blocks generated by miner software that uses the rpc call getblocktemplate.
A vote of zero in either B or EB is distinct from garbage.
Makes validation compatible with BIP100.
|
Added compact blocks update from @dagurval. |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are for Bitcoin XT. For the Bitcoin Core version, see bitcoinxt/bitcoin#1.
Implementation of the BIP100 specification as published.
Full nodes need no configuration to follow the network sizelimit as determined by BIP100. Miners may set their coinbase /B vote using
-maxblocksizevote=<n> Set vote for maximum block size in megabytes (default: network sizelimit)Most RPC's return the sizelimit as of the current tip, consistent with the other attributes.
getblocktemplatereturns the sizelimit for a block built on the current tip, which may change by a factor of up to 1.05 at the start of a difficulty interval, per the specification.On first run, block index entries starting at the activation height (449568, which was in January 2017) are updated to track miner size votes and sizelimit history. Use
-debug=reindex(NOT-reindex) to see the progress of this update.The current network sizelimit is published in the user agent string as EB.
This implementation does not lift the 32MB physical MAX_SIZE limit. File buffer sizes, sanity checks in bitcoin-tx, verifytxoutproof, and merkle blocks also continue to reference MAX_BLOCK_SIZE as a general scale indicator.