Add power consumption metric to power supply monitoring module

[eyusupov]

Summary

Add a new metric for battery discharge rate (/sys/class/battery/<BAT>/power_now).

Test Plan

• Single battery when charging
• Single battery when discharging

Additional Information

There is a new metric that allows to track the machine (usually laptop) power consumption.
While it is possible to gauge this using existing power capacity metric, it is not very granular does not show the rate of discharge very clearly.
With this change it should possible to correlate other metrics with power consumption.

There seem to be some issues with the sections (BAT0 has appeared as the section heading and capacity metric is displayed under charge section). I think the reason might be in the dashboard code which source is not included in the repo.

[CLAassistant]

All committers have signed the CLA.

[ilyam8]

Hey, @eyusupov 👋 Thanks for the contribution!

There seem to be some issues with the sections

The subsection name is the 4th parameter in rrdset_create_localhost(). I fixed them in #17338.

[ilyam8]

@eyusupov I merged #17338, please

• Rebase/resolve merge conflicts.
• Update the screenshot in the PR description.

[eyusupov]

I rebased my branch and updated the section (and priority) for the new metric, but it seems like it has stopped displaying completely now.

[eyusupov]

[eyusupov]

This is the new screenshot:

I was expecting power to be showing after charge due to the priority NETDATA_CHART_PRIO_POWER_SUPPLY_POWER. Am I missing or misunderstanding something? Showing it the way it is is also fine for me, but the code should reflect it then.

[ilyam8]

@eyusupov I see that the priority is NETDATA_CHART_PRIO_POWER_SUPPLY_CAPACITY for charge, energy, and voltage.

You can add priority to struct ps_property and use it later when creating charts.

[eyusupov]

Updated the priorities, but for some reason energy is still reported before power

[thiagoftsm]

I suggest instead to test prop->fd != -1 again, you write it as an else for previous block.

[thiagoftsm]

When you create a macro (define) above, please, do not forget to change here.

[eyusupov]

I prepared another PR with the same change, where I have unified the code for single and multi-dimensional properties #17346. Let me know if you think it's better or if I should finish that one instead.

[eyusupov]

Screenshot from the latest test run:

[thiagoftsm]

I prepared another PR with the same change, where I have unified the code for single and multi-dimensional properties #17346. Let me know if you think it's better or if I should finish that one instead.

Hello,

I am sorry for the delay, I got some days off.
I suggest we finish this first, so you can st the other as draft for a while.

[thiagoftsm]

@ilyam8 I cannot see on my host the charts, can you see on yours?

[thiagoftsm]

I do not have the file power_now on my environments, but the plugin is running as expected with these changes. I am going to approve waiting for other reviewers that have conditions to see the chart.
Thank you @eyusupov !