Add power consumption - v2 #17346
Add power consumption - v2 #17346
Conversation
github-actions
bot
added
area/docs
area/web
area/collectors
|
Hello @eyusupov, Now that other PR is merged, please, rebase this PR, and we will have conditions to proceed with it. Best regards! |
eyusupov
force-pushed
the
add-power-consumption-v2
branch
from
c2e8d64
to
d2cdbf5
Compare
github-actions
bot
removed
area/docs
area/web
area/metadata
|
|
|
Updated |
eyusupov
force-pushed
the
add-power-consumption-v2
branch
from
e1c35a9
to
54ddea2
Compare
| const char *ps_property_dim_names[] = {"empty_design", "empty", "now", "full", "full_design", | ||
| "empty_design", "empty", "now", "full", "full_design", | ||
| "min_design", "min", "now", "max", "max_design"}; | ||
| const char *ps_property_dim_names[] = { |
There was a problem hiding this comment.
Hello,
I've tested your code, and it seems to be functional. However, upon reviewing it, I've come across some changes that I'm not entirely convinced about. Let me explain:
We're introducing two new rows here, along with a NULL at the end of each, but the "table" doesn't maintain a consistent number of columns for each line. This necessitates changes to the subsequent code.
I believe there's potential to simplify the changes you're proposing. My suggestion is to maintain the previous format of "ps_property_dim_names." Instead, consider creating a function within the loop that handles the necessary arguments for running the algorithm.
Following these adjustments, before entering the loop, you could execute calls for the lines that don't require five values, and then proceed with the loop for the remaining code.
I bring this up because I believe that introducing a "table" with varying patterns could potentially confuse some developers. 🤔
Summary
Reworked #17329 with the reduced amount of code.
Test Plan
Additional Information