Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unskip v8-updates/test-linux-perf-logger #52869

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lukealbao
Copy link
Contributor

@lukealbao lukealbao commented May 7, 2024

This patch fixes #51308. It includes commit to re-enable the test by reverting #52821.

Explanation

This test suite is a dependency-free port of test/v8-updates/test-linux-perf.js. In both cases, js code is evaluated in a child process with v8 options set to emit a symbol table for perf(1). Verification is done by regex lookup. In the output, a function foo will be distinguished as compiled or interpreted based on a unary prefix character. Test cases use v8 option arguments to the child process to ensure compilation when applicable.

In 2023 (I don't know how to identify the release version), v8 added a new additional flag to guard optimization (link). This patch includes that in the child process options.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 7, 2024
@lukealbao lukealbao changed the title Gh 51308 mainline test: unskip v8-updates/test-linux-perf-logger May 7, 2024
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 7, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented May 7, 2024

08:06:57 ok 2 v8-updates/test-linux-perf-logger
08:06:57   ---
08:06:57   duration_ms: 709.58200
08:06:57   ...
08:06:57 
08:06:57 All tests passed.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken test/v8-updates/test-linux-perf-logger
6 participants