Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unskip v8-updates/test-linux-perf-logger #52869

Closed
wants to merge 4 commits into from
Closed

test: unskip v8-updates/test-linux-perf-logger #52869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdc89d0
test: unskip v8-updates/test-linux-perf-logger
lukealbao May 7, 2024
03f1dda
test: Revert "test: skip v8-updates/test-linux-perf-logger"
lukealbao May 7, 2024
d261dfa
lint fix
lukealbao May 7, 2024
62cef20
lint fix indent
lukealbao May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions test/v8-updates/test-linux-perf-logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
//
// NOTE: This test runs only on linux, as that is the only platform supported by perf, and
// accordingly the only platform where `perf-basic-prof*` v8 flags are available.

//
// MAINTAINERS' NOTE: As of early 2024, the most common failure mode for this test suite
// is for v8 options to change from version to version. If this suite fails, look there first.
// We use options to forcibly require certain test cases to JIT code, and the nodeFlags to do
// so can change.

const common = require('../common');
if (!common.isLinux) {
Expand Down Expand Up @@ -48,7 +52,8 @@ const testCases = [
},
{
title: '--perf-basic-prof compiled',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan'],
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'test-regex',
'~functionOne .+/linux-perf-logger.js',
Expand All @@ -66,7 +71,8 @@ const testCases = [
},
{
title: '--perf-basic-prof-only-functions compiled',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan'],
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
Expand Down
2 changes: 0 additions & 2 deletions test/v8-updates/v8-updates.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ prefix v8-updates
[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/50079
test-linux-perf: SKIP
# https://github.com/nodejs/node/issues/51308
test-linux-perf-logger: SKIP

[$system==win32]

Expand Down