Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow recursive testing #52901

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented May 8, 2024

Blocks #52875

This PR gives the test runner support for recursive searching for test files. This is being backported, as in #52875 (and similar future PRs), testing will (hopefully) be moved to subdirectories.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels May 8, 2024
@RedYetiDev RedYetiDev added backported-to-v18.x PRs backported to the v18.x-staging branch. backported-to-v20.x PRs backported to the v20.x-staging branch. backported-to-v21.x PRs backported to the v21.x-staging branch. labels May 8, 2024
@RedYetiDev
Copy link
Member Author

@nodejs/testing
@nodejs/backporters

@RedYetiDev RedYetiDev added review wanted PRs that need reviews. and removed backported-to-v21.x PRs backported to the v21.x-staging branch. labels May 8, 2024
@RedYetiDev
Copy link
Member Author

By the way, this PR should be backported to 18 and 20, I'm not sure if the labels I applied are correct.

@richardlau richardlau removed backported-to-v18.x PRs backported to the v18.x-staging branch. backported-to-v20.x PRs backported to the v20.x-staging branch. labels May 8, 2024
@RedYetiDev
Copy link
Member Author

Thanks @richardlau, I'm new to backporting. For the future, what would be the appropriate labels?

@richardlau
Copy link
Member

Possibly lts-watch-*, although strictly speaking it shouldn't be necessary for a release line in active LTS (e.g. 20.x).

Refer to https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

@RedYetiDev
Copy link
Member Author

Possibly lts-watch-*, although strictly speaking it shouldn't be necessary for a release line in active LTS (e.g. 20.x).

Refer to main/doc/contributing/backporting-to-release-lines.md

Okay, thanks. Should I add lts-watch for 18 and 20? This change should be the exact same for the other lines, as I don't think the files that this is editing have changed.

test/.eslintrc.yaml Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev requested a review from targos May 9, 2024 13:03
@RedYetiDev
Copy link
Member Author

RedYetiDev commented May 9, 2024

@targos, is there anything in particular I need to do for the backport?

@targos
Copy link
Member

targos commented May 10, 2024

As @richardlau suggested: add lts-watch-* labels.

@RedYetiDev RedYetiDev added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants