WebUI: clean up code #20728
Merged
WebUI: clean up code #20728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use proper function for finding match. Use strict comparison operators.
Piccirello
previously approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Is it worth enforcing strict equality checking via eslint? https://eslint.org/docs/latest/rules/eqeqeq
Of course! I've added 2 more commits. |
Chocobo1
added
the
Code cleanup
xavier2k6
approved these changes
Apr 27, 2024
Piccirello
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper function for finding match.
Use strict comparison operators.
https://mootools.net/core/docs/1.6.0/Core/Core#Deprecated-Functions
I intend to use 'create a merge commit' for merging.