Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2: add Spanish translation #12742

Merged
merged 14 commits into from May 19, 2024
Merged

d2: add Spanish translation #12742

merged 14 commits into from May 19, 2024

Conversation

kant
Copy link
Member

@kant kant commented May 6, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the translation Translate pages from one language to another. label May 6, 2024
Copy link
Member

@tricantivu tricantivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the English page placeholders for output files should be updated:

{{path/to/output_file.[svg|png]}}

pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
kant and others added 9 commits May 15, 2024 17:41
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
pages.es/common/d2.md Outdated Show resolved Hide resolved
pages.es/common/d2.md Outdated Show resolved Hide resolved
kant and others added 2 commits May 16, 2024 12:44
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@sebastiaanspeck
Copy link
Member

Could you please update the English page as well, as @tricantivu suggested?

@kant
Copy link
Member Author

kant commented May 17, 2024

@sebastiaanspeck Done

@kbdharun kbdharun mentioned this pull request May 17, 2024
5 tasks
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tricantivu We don't support the optional placeholder usage (since the style guide refresh a month ago), feel free to checkout https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#optional-placeholders. I will mark this pull request as draft for now and will update the English page PR for the suggested usage.

@kbdharun kbdharun marked this pull request as draft May 17, 2024 16:01
@sebastiaanspeck
Copy link
Member

The English page got updated, could you please update the Spanish page as well?

@kant
Copy link
Member Author

kant commented May 18, 2024

@sebastiaanspeck Done

> Un lenguaje moderno de scripting de diagramas que convierte texto en diagramas.
> Más información: <https://d2lang.com/tour/man>.
- Compila y renderiza un archivo fuente D2 en un archivo SVG o PNG:

This comment was marked as duplicate.

This comment was marked as duplicate.

> Un lenguaje moderno de scripting de diagramas que convierte texto en diagramas.
> Más información: <https://d2lang.com/tour/man>.
- Compila y renderiza un archivo fuente D2 en un archivo SVG o PNG:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of the first example was recently updated from:
- Compile and render a D2 source file into an SVG or PNG file:
to:
- Compile and render a D2 source file into an output file:.
This should be updated there too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pages.es/common/d2.md Show resolved Hide resolved
@spageektti spageektti marked this pull request as ready for review May 19, 2024 17:57
@kbdharun kbdharun merged commit dda5724 into main May 19, 2024
7 checks passed
@kbdharun kbdharun deleted the kant-patch-1 branch May 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants